feat: -parse:goal=Module#339
Merged
Merged
Conversation
gibson042
approved these changes
May 11, 2026
jhnaldo
requested changes
May 15, 2026
Contributor
jhnaldo
left a comment
jhnaldo
left a comment
There was a problem hiding this comment.
Thanks for the PR! The new parsing goal feature (-parse:goal) looks good to me.
Just one minor request: could you update the .completion file as well? It gets updated automatically via sbt test. I would have done it myself, but I lack the permissions to edit your PR branch. I'll merge it immediately after this update. Thank you!
Contributor
Author
done, in a fixup. Let me know if you would prefer that I amend and force-push. |
jhnaldo
approved these changes
May 15, 2026
Contributor
|
Thanks! I merged this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
support parsing a .js file as a Module
cc @erights @gibson042 @michaelfig